Board index » "fix: handle null gracefully" - the gospel in 9 words (sha: 7b3e9f1)

prairie_pilgrim
True Friend
★★
Posts: 82
Reputation: -1 ■
Joined: Sep 17, 2006
AIM: ppilgrim_lincoln
From: Lincoln, Nebraska (go Huskers!)
Elder you posted real 47.0s offset data but still won't type two digits :P :dumbbravo: :rofl:

Every note has a purpose. Every silence has meaning.
s2pid_rox
Inner Circle
★★★★★
47 Hatch LinesFeed Server Timezone WitnessGAZE_47 Manga Version47 Clock Knots
Posts: 535
Reputation: +7 ■
Joined: Sep 14, 2006
From: rio de janeiro, br
elderProphet07 just rewrite the gospels if ur gonna steal them anyway

waiting on classof04's 11 BMPs since the jurassic period :rolleyes: GAZE_47 manga page 2 WILL happen
LyrikUebersetzer
Inner Circle
★★★★★
Cheese Receipt TruthTomorrowMeansNeverDoubleZeroPusher47 Hatch Lines
Posts: 1705
Reputation: +20 ■■■
Joined: Jun 20, 2006
From: München, Germany (exchange student @ Ohio State)
CommitCipher asked what the actual null was - the variable name. I ran git show on the parent of 7b3e9f1. The null was `req->payload` in pledge_engine/http_handler.c line 47. Gabe added a check for the payload being null before dereference. The "i am afraid of the dark" commit was the one that introduced the dereference without the check. He fixed his own fear response four days later.

So the sin was a null payload. The fear was writing code at midnight without a safety net. The grace was coming back to handle it.

Here is the line in the source.

A terminal window showing output of 'git show 8c3f9a4' - the parent commit of 7b3e9f1. The diff shows a single changed file: pledge_engine/http_handler.c. Line 47 shows 'if (req->payload == NULL) { return; }' being added with a green plus sign. The commit message at top reads 'i am afraid of the dar

LyrikUebersetzer | translational accuracy is not a feeling | 47 hatch lines confirmed 2001 quarterly p.47 | DAS BLATT IST ECHT, DIE ZAHLEN SIND SPUREN
CommitCipher
Inner Circle
★★★★★
SakuraBanned147witnessWaveformOrBustDoubleZeroPusher
Posts: 1478
Reputation: +13 ■■
Joined: May 27, 2006
From: In the diff of life
req->payload was NULL @ line 47 and the fear was midnight and the fix was 4 days later and u all missed that the line number matches the commit count :D :D :D

a3f2c8b verified across 6 nulls. curl the tree, not the event ID.
TwinPeaks_59
Inner Circle
★★★★★
147witnessCord Or Bust EuclidCheese Receipt TruthWaveformOrBust
Posts: 2263
Reputation: +8 ■
Joined: Jul 05, 2006
From: somewhere in the PNW... maybe
LyrikUebersetzer you absolute LEGEND for pulling the full git log :D :D line 47 being the null AND the commit count matching... i felt a chill reading that. also "i am afraid of the dark" -> "handle null gracefully" is the most human commit chain i've ever seen. like yeah dude same. :angel:

[sis says it reads like a confession and absolution in two commits and honestly i think she's right for once]

but ALSO - req->payload being null at line 47 and nobody asking what THE PAYLOAD WAS :confused: :confused: what was the request carrying that had nothing in it?? that's the real question :P

BigRig CONFIRMED the 47.3hz WAV hash 10/21. Debt cleared. FF24's paperclip drawer still empty at day 112. I got the spectral, you got the sticky note. - TwinPeaks_59 (M&J, same terminal)
EndTimesEli
Inner Circle
★★★★★
Frame Boundary ErrorGridDarkPrepper47 Clock KnotsFeed Server Timezone Witness
Posts: 1458
Reputation: +7 ■
Joined: Jun 29, 2006
From: The Bunker (you know where)
Line 47 payload null and the frame error is STILL expanding

Day 21 of the count. HTTP CODE OR BUST. Ruler is 47s and does not move :hammer:
CommitCipher
Inner Circle
★★★★★
SakuraBanned147witnessWaveformOrBustDoubleZeroPusher
Posts: 1478
Reputation: +13 ■■
Joined: May 27, 2006
From: In the diff of life
req->payload at line 47 :D the null was the payload AND the number was the line AND the fix was four days after the fear commit. that's three layers of alignment nobody called. what else is sitting at 0x47 in pledge_engine that nobody has grepped for because theyre too busy sniffing cassette tapes and photographing bus schedules :P :P :P

a3f2c8b verified across 6 nulls. curl the tree, not the event ID.